-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package command - add support for multi modules #816
Conversation
cee80fd
to
34eebfd
Compare
34eebfd
to
ec93ef9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the minor comment, LGTM!
f5844e9
to
a30e455
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we update js documentation?
This feature is already mentioned in the documentation, it just wasn't working :) https://scala-cli.virtuslab.org/docs/reference/cli-options/#--js-module-split-style |
I think, that I confusingly named PR, it is more bug fixes. Because if someone run
he gets an error that |
That is valid, however current Scala JS guide does not have a section about publishing so I think we should describe the publishing for JS. We have a small section at So I am merging this PR for now, @lwronski could you review the documentation for packaging in JS and create a follow up PR if needed? |
Note that publishing (i.e., uploading SJSIR files to Maven) is different from packaging (linking SJSIR files into JS files). |
No description provided.